Merge pull request #122 from jhj0517/patch/docker

Install.sh

@@ -1,21 +0,0 @@
-#!/bin/bash
-
-if [ ! -d "venv" ]; then
-    echo "Creating virtual environment..."
-    python -m venv venv
-fi
-
-source venv/bin/activate
-pip install -r requirements.txt
-
-if [ $? -ne 0 ]; then
-    echo ""
-    echo "Requirements installation failed. please remove venv folder and run install.sh again."
-    deactivate
-    exit 1
-fi
-
-echo ""
-echo "Requirements installed successfully."
-
-deactivate

README.md

@@ -22,7 +22,8 @@ If you wish to try this on Colab, you can do it in [here](https://colab.research
   - Translate subtitle files using DeepL API
 
 # Installation and Running
-## Prerequisite
+- ## On Windows OS
+### Prerequisite
 To run this WebUI, you need to have `git`, `python` version 3.8 ~ 3.10, `CUDA` version above 12.0 and `FFmpeg`.
 
 Please follow the links below to install the necessary software:
@@ -33,7 +34,7 @@ Please follow the links below to install the necessary software:
 
 After installing FFmpeg, **make sure to add the `FFmpeg/bin` folder to your system PATH!**
 
-## Automatic Installation
+### Automatic Installation
 If you have satisfied the prerequisites listed above, you are now ready to start Whisper-WebUI.
 
 1. Run `Install.bat` from Windows Explorer as a regular, non-administrator user. ( Run `install.sh` if you are using Mac ) 
@@ -44,21 +45,32 @@ If you have satisfied the prerequisites listed above, you are now ready to start
 
 And you can also run the project with command line arguments if you like by running `user-start-webui.bat`, see [wiki](https://github.com/jhj0517/Whisper-WebUI/wiki/Command-Line-Arguments) for a guide to arguments.
 
-## Using Docker
+- ## Docker ( On Other OS )
 
-1. build the image
+1. Build the image
 
 ```sh
 docker build -t whisper-webui:latest . 
 ```
 
-2. run the container
+2. Run the container with commands
 
+- For bash :
 ```sh
 docker run --gpus all -d \
 -v /path/to/models:/Whisper-WebUI/models \
 -v /path/to/outputs:/Whisper-WebUI/outputs \
 -p 7860:7860 \
+-it \
+whisper-webui:latest --server_name 0.0.0.0 --server_port 7860
+```
+- For PowerShell:
+```shell
+docker run --gpus all -d `
+-v /path/to/models:/Whisper-WebUI/models `
+-v /path/to/outputs:/Whisper-WebUI/outputs `
+-p 7860:7860 `
+-it `
 whisper-webui:latest --server_name 0.0.0.0 --server_port 7860
 ```
 

start-webui.sh

@@ -1,12 +0,0 @@
-#!/bin/bash
-
-source venv/bin/activate
-
-PYTHON="venv/bin/python"
-echo "venv ${PYTHON}"
-echo ""
-
-python app.py $*
-
-deactivate
-